Meson/wren
1
0
Fork 0
forked from Mirror/wren
Code Pull Requests Activity

Do not allow inheriting built-in classes Num, Bool and Null (#831)

Browse Source 
* Do not allow inheriting `Num`, `Bool` and `Null`. fixes #830
This commit is contained in:
Chayim Refael Friedman
2020-10-26 17:39:36 +02:00
committed by GitHub
parent ad4e039187
commit 44d6d20586
4 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vm/wren_vm.c
View File

@ -512,7 +512,10 @@ static Value validateSuperclass(WrenVM* vm, Value name, Value superclassValue,
superclass == vm->listClass ||
superclass == vm->mapClass ||
superclass == vm->rangeClass ||
superclass == vm->stringClass)
superclass == vm->stringClass ||
superclass == vm->boolClass ||
superclass == vm->nullClass ||
superclass == vm->numClass)
{
return wrenStringFormat(vm,
"Class '@' cannot inherit from built-in class '@'.",

1
test/language/inheritance/inherit_from_bool.wren Normal file
View File

@ -0,0 +1 @@
class Subclass is Bool {} // expect runtime error: Class 'Subclass' cannot inherit from built-in class 'Bool'.

1
test/language/inheritance/inherit_from_null_class.wren Normal file
View File

@ -0,0 +1 @@
class Subclass is Null {} // expect runtime error: Class 'Subclass' cannot inherit from built-in class 'Null'.

1
test/language/inheritance/inherit_from_num.wren Normal file
View File

@ -0,0 +1 @@
class Subclass is Num {} // expect runtime error: Class 'Subclass' cannot inherit from built-in class 'Num'.