Mirror/wren
1
0
Fork 1
mirror of https://github.com/wren-lang/wren.git synced 2026-01-11 14:18:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Check for duplicates when adding constants.

Browse Source 
This saves a little memory, but, more importantly, allows us to support
functions with large numbers of repeated constants.
This commit is contained in:
Bob Nystrom
2016-08-16 07:24:04 -07:00
parent 500c7b0426
commit 08eceb7382
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vm/wren_compiler.c
View File

@ -465,6 +465,17 @@ static int addConstant(Compiler* compiler, Value constant)
{
if (compiler->parser->hasError) return -1;
// See if we already have a constant for the value. If so, reuse it.
// TODO: This is O(n). Do something better?
for (int i = 0; i < compiler->fn->constants.count; i++)
{
if (wrenValuesEqual(constant, compiler->fn->constants.data[i]))
{
return i;
}
}
// It's a new constant.
if (compiler->fn->constants.count < MAX_CONSTANTS)
{
if (IS_OBJ(constant)) wrenPushRoot(compiler->parser->vm, AS_OBJ(constant));